This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(promise): include stack trace in an unhandlerd promise #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliemr
reviewed
Sep 20, 2016
| Promise.reject('rejectedErrorShouldBeHandled'); | ||
| expect(promiseError).toBe(null); | ||
| error = new Error('rejectedErrorShouldBeHandled'); | ||
| Promise.reject(error); |
There was a problem hiding this comment.
Why remove the expectation that promiseError is null here?
There was a problem hiding this comment.
Opps, that was on accident, will add it back.
|
Other than that question, LGTM. |
mhevery
force-pushed
the
better-errors
branch
from
4e00349
to
399db61
Compare
mhevery
force-pushed
the
better-errors
branch
from
399db61
to
2e19246
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.